Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Introduce try-except block to catch exceptions in flwr ls #4612

Merged
merged 9 commits into from
Dec 4, 2024
Merged

feat(framework) Introduce try-except block to catch exceptions in flwr ls #4612

merged 9 commits into from
Dec 4, 2024

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Dec 2, 2024 •
edited
Loading

The try-except block is required to catch any exceptions raised during flwr ls and print a JSON output for errors.

Merge after:

Merge before:

@chongshenng chongshenng changed the base branch from main to refactor-ls-table-format December 2, 2024 12:19
@chongshenng chongshenng marked this pull request as ready for review December 2, 2024 12:40
This was referenced Dec 3, 2024
Merged
Merged
panh99
panh99 reviewed Dec 3, 2024
View reviewed changes
src/py/flwr/cli/ls.py Outdated Show resolved Hide resolved
src/py/flwr/cli/ls.py Show resolved Hide resolved
panh99
panh99 previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from refactor-ls-table-format to main December 4, 2024 11:03
@danieljanes danieljanes dismissed panh99’s stale review December 4, 2024 11:03

The base branch was changed.

@danieljanes danieljanes enabled auto-merge (squash) December 4, 2024 11:11
@danieljanes danieljanes merged commit 2b17349 into main Dec 4, 2024
55 checks passed
@danieljanes danieljanes deleted the print-errors-as-json branch December 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@panh99 panh99 panh99 left review comments

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chongshenng @danieljanes @panh99